Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add 1d cylinder and sphere #5189

Open
wants to merge 54 commits into
base: development
Choose a base branch
from

Conversation

dpgrote
Copy link
Member

@dpgrote dpgrote commented Aug 28, 2024

This large PR adds 1d cylindrical and spherical geometries.

This touches many files, every place that has a dependency on the dimensionality. One complication in these geometries is that there is no z-axis, so some parts of the code (the moving window, boosted frame, and BTD diagnostics) are not applicable, and require changes there to avoid compilation problems.

Current status:

  • cylindrical works, producing correct results in Langmuir test
  • spherical works, producing correct results in Langmuir test

@dpgrote dpgrote added the enhancement New feature or request label Aug 28, 2024
@ax3l ax3l changed the title [WIP]Add 1d cylinder and sphere [WIP] Add 1d cylinder and sphere Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant