Added declaration and initialization of a list of beamline elements. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
reviewed
Dec 5, 2021
ax3l
reviewed
Dec 5, 2021
ax3l
reviewed
Dec 5, 2021
ax3l
reviewed
Dec 5, 2021
ax3l
force-pushed
the
list-of-elements
branch
3 times, most recently
from
99dbc93
to
097d1fa
Compare
ax3l
force-pushed
the
list-of-elements
branch
2 times, most recently
from
97711fc
to
7038848
Compare
This allows us to create a list of multiple (known) types.
CUDA builds for NVCC 11.0.2 fail with
```
error #3206-D: An extended __device__ lambda cannot be defined inside a generic lambda expression("operator()").
```
if we try to nest out `std::visit` and `ParallelFor` device lambdas.
So, as a work-around, we isolate the single particle push out into a
C++ functor.
Wow, 2010 feels.
|
Work-around for CUDA: submitted as Nvidia request for Enhancement with BugID 3458976 Tiny demonstrator in https://cuda.godbolt.org/z/39e4q53Ye |
ax3l
added a commit
that referenced
this pull request
Dec 5, 2021
More context for the work-around used in #21
This was referenced Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt at initializing a list of beamline elements defining the lattice. For now, the list includes only drift elements. The main work is done in the function initElements() in ImpactX.cpp.
Request sanity check that this makes some sense before proceeding further.