Add transverse kicker #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
reviewed
Aug 2, 2023
ax3l
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Thank you, that looks great.
I added a small commit using self-describing arguments at the call site for the kicker: a C++ enum and strings when describing the unit system of the Kicker. I also clarified a few details on the normalization of the dimensionless option.
- Modified the initial beam size in the IOTA lens benchmark example. - Added 2 benchmarks of 3D space charge for initial testing. - Add documentation for 2 benchmarks with space charge. - Add a benchmark example with space charge and periodic s-dependent focusing. - Added an s-dependent example using a Kurth beam without space charge. - Modified tolerance for IOTA lens benchmark example. Reduced tolerance to account for smaller initial beam size and improved preservation of invariants of motion. - Modified tolerances of space charge examples to allow CI tests to pass when space charge is not active. - Modified tolerance for space charge examples. These should fail unless space charge is turned on.
Selected numerical values for amr.n_cell, lattice.nslice, and geometry.prob_relative.
This is not part of this PR.
for more information, see https://pre-commit.ci
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
ax3l
approved these changes
Aug 9, 2023
Relax tolerance slightly.
Update the C++ API to use an enum for the unit system and the Python API & inputs file syntax to accept a string. That makes the parameters at the call sites self-describing. Also clarifies in doc strings what dimensionless is referring to (units of magnetic rigidity of the reference particle).
cemitch99
commented
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a thin transverse kicker element, corresponding to MAD-X elements 'hkicker', 'vkicker', 'kicker', and 'tkicker'.