-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clang-tidy CI test #56
base: development
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, all CI checks seem successful, so it's probably ready to merge. I left only two minor notes related to inline comments that might have been copied from WarpX.
@@ -0,0 +1,30 @@ | |||
#!/usr/bin/env bash | |||
# | |||
# Copyright 2023 The WarpX Community |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be BLAST instead of WarpX from now on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right
Co-authored-by: Edoardo Zoni <59625522+EZoni@users.noreply.github.com>
This PR introduces a new CI test that runs
clang-tidy
on all the tests and demos ofpicsar_qed
.Included/excluded
clang-tidy
checks as well as check options can be found in.clang-tidy
. For the moment, this configuration file is identical to what is used in WarpX.The PR also fixes all the issues found with the new
clang-tidy
CI test. In order to fix some issues properly, now C++17 is used (up until now the library used C++14)