Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

[Backport] Python: Script Error is Test Error #20

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Dec 10, 2021

Make sure we report crashes as failures, even if pltfile comparisons are off.

Backport a part of AMReX-Codes#57:

Similar to #18

Make sure we report crashes as failures, even if pltfile comparisons
are off.

Backport a part of AMReX-Codes#57:
- AMReX-Codes@783c38d

Co-authored-by: Andrew Myers <atmyers2@gmail.com>
@ax3l ax3l added the bug Something isn't working label Dec 10, 2021
@ax3l ax3l requested review from atmyers and EZoni December 10, 2021 01:14
regtest.py Outdated Show resolved Hide resolved
Copy link
Member

@EZoni EZoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Axel!

@ax3l ax3l merged commit a2810a3 into ECP-WarpX:master Dec 10, 2021
@ax3l ax3l deleted the fix-crashedIsFailure branch December 10, 2021 01:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants