Folder #199
Merged
Folder #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #199 +/- ##
===========================================
+ Coverage 92.70% 92.86% +0.16%
===========================================
Files 22 22
Lines 1657 1666 +9
===========================================
+ Hits 1536 1547 +11
+ Misses 121 119 -2
☔ View full report in Codecov by Sentry. |
sadrasabouri
requested changes
Nov 7, 2023
opem/Functions.py
Outdated
Comment on lines
308
to
309
| if not os.path.exists(Folder): | ||
| os.mkdir(Folder) |
There was a problem hiding this comment.
Imagine the case that Folder='path/to/folder' and we do not have the path folder. In that case it would raise error FileNotFoundError: [Errno 2] No such file or directory: 'path/to/folder'.
It works just for one layer of folder creation.
There was a problem hiding this comment.
fixed in 4745d34
| os.mkdir(Folder) | ||
| sim_folder = os.path.join(Folder, Title) | ||
| if not os.path.exists(sim_folder): | ||
| os.mkdir(sim_folder) |
There was a problem hiding this comment.
fixed in 4745d34
opem/Functions.py
Outdated
Comment on lines
344
to
348
| if not os.path.exists(Folder): | ||
| os.mkdir(Folder) | ||
| sim_folder = os.path.join(Folder, Title) | ||
| if not os.path.exists(sim_folder): | ||
| os.mkdir(sim_folder) |
There was a problem hiding this comment.
fixed in 4745d34
opem/Functions.py
Outdated
Comment on lines
384
to
388
| if not os.path.exists(Folder): | ||
| os.mkdir(Folder) | ||
| sim_folder = os.path.join(Folder, Title) | ||
| if not os.path.exists(sim_folder): | ||
| os.mkdir(sim_folder) |
There was a problem hiding this comment.
fixed in 4745d34
sadrasabouri
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#174
What does this implement/fix? Explain your changes.
Folderparameter added toStatic_AnalysisfunctionFolderparameter added toDynamic_AnalysisfunctionAny other comments?