Use a time template in module documentation generation #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocaisa
commented
Aug 7, 2024
|
Ok, this is ready for showtime |
|
Example of the change that results at https://github.com/EESSI/docs/actions/runs/10287388444/job/28470290282#step:5:3933 |
boegel
requested changes
Aug 8, 2024
| @@ -34,7 +34,10 @@ jobs: | |||
| cp docs/available_software/data/json_data.json docs/available_software/data/json_data.json.orig | |||
| cp docs/available_software/data/json_data_detail.json docs/available_software/data/json_data_detail.json.orig | |||
|
|
|||
| export TIME_GENERATED_TEMPLATE="{{ generated_time }}" | |||
There was a problem hiding this comment.
Why the side-step here via this environment variable, why not just "hardcode" {{ generated_time }} in the generated pages?
There was a problem hiding this comment.
So that others sites can use the script without being forced to take the same approach.
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
boegel
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #255