Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay for compat layer EESSI 2023.02 #84

Merged
merged 43 commits into from
Feb 24, 2023
Merged

Conversation

poksumdo
Copy link

The overlay for 2022.11 required some changes:

  • removed test for sys-cluster/lmod in etc/portage/package.env because some tests were failing
  • new package sets for eessi-2022.1{0,1}-linux-{aarch64,x86_64} (package sets for 2022.10 were needed for a previous build for version 2022.10; sets for 2022.10 and 2022.11 are identical; set for 2022.10 might not be needed anymore, was only used for NESSI tests)
    • these package sets are nearly identical to the ones for 2021.12 with the only change that sys-libs/pam-1.5.2::eessi has been removed
  • archspec ebuild file needed to be updated (adding DISTUTILS_USE_PEP517=poetry as described in https://projects.gentoo.org/python/guide/distutils.html#basic-use-pep-517-mode); the Manifest file was updated accordingly
  • reframe ebuild file needed to be updated (adding DISTUTILS_USE_PEP517=setuptools as described in https://projects.gentoo.org/python/guide/distutils.html#basic-use-pep-517-mode, also removing dev-python/pyproject2setuppy...); the Manifest file was updated accordingly

truib and others added 10 commits October 5, 2022 21:03
etc/portage/package.env Outdated Show resolved Hide resolved
Copy link
Collaborator

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the 2022.10 sets, they probably don't belong here since we'll never use them in EESSI?

We should also at least make an attempt to build the compat layer for ppc64le, and if that works without trouble deploy it for 2022.11 too (but opt out of building stuff for it in the software layer)

sys-cluster/reframe/reframe-3.9.1.ebuild Outdated Show resolved Hide resolved
sys-cluster/reframe/reframe-3.9.1.ebuild Outdated Show resolved Hide resolved
etc/portage/sets/eessi-2022.11-linux-x86_64 Outdated Show resolved Hide resolved
etc/portage/sets/eessi-2022.11-linux-x86_64 Outdated Show resolved Hide resolved
etc/portage/sets/eessi-2022.11-linux-x86_64 Outdated Show resolved Hide resolved
Those were only temporarily used for tests with NESSI. Likely they will never be used with EESSI. They are also identical to version 2022.11, so could be recreated easily.
@poksumdo
Copy link
Author

Sets for 2022.10 have been removed. Set eessi-2022.11-ppc64le has been added.

@boegel
Copy link
Collaborator

boegel commented Oct 31, 2022

Sets for 2022.10 have been removed. Set eessi-2022.11-ppc64le has been added.

Once we have the companion PR for the EESSI/compatibility-layer repo, I can test the installation on ppc64le

Added three more sed substitution expression to catch the remaining
failing tests. Removed temporary debug output.
@trz42
Copy link
Contributor

trz42 commented Nov 2, 2022

Patch file sys-cluster/lmod/files/lmod-8.7.13-fix-failing-tests-with-EESSI.patch fixes TACC/Lmod#611

Skip patch for fix failing tests to verify if problem persists in version
8.7.14.
@bedroge
Copy link
Collaborator

bedroge commented Feb 17, 2023

@trz42 I made a PR trz42#19 that makes some modifications/additions to your PR as a first step towards 2023.02.

Updates for EESSI compat layer 2023.02
@bedroge bedroge changed the title Overlay for compat layer EESSI 2022.11 Overlay for compat layer EESSI 2023.02 Feb 24, 2023
@bedroge
Copy link
Collaborator

bedroge commented Feb 24, 2023

Not sure if we need the different Lmod versions, and the same for ReFrame (as we're kicking them out of the compat layer), but I'll leave them in for now.

bedroge
bedroge previously approved these changes Feb 24, 2023
Copy link
Collaborator

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bedroge Let's bump archspec to 0.2.0 in scripts/eessi_sets.yml?

And maybe also specify Lmod version explicitly?

@bedroge
Copy link
Collaborator

bedroge commented Feb 24, 2023

@bedroge Let's bump archspec to 0.2.0 in scripts/eessi_sets.yml?

And maybe also specify Lmod version explicitly?

Ah, yes, overlooked that, thanks. Fixed in trz42#20.

Few more updates for 2023.02 set
@boegel boegel merged commit cf32b6c into EESSI:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

5 participants