Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update CI workflow for checking for missing installations #389

Merged
merged 3 commits into from
Nov 27, 2023
Merged

update CI workflow for checking for missing installations #389

merged 3 commits into from
Nov 27, 2023

Conversation

boegel
Copy link
Contributor

@boegel boegel commented Nov 25, 2023 •
edited by trz42
Loading

CI should fail until we have an EasyBuild installed in software.eessi.io (the load_easybuild_module.sh used in check_missing_installations.sh will fail):

Fixes #349

@eessi-bot eessi-bot
Copy link

eessi-bot bot commented Nov 25, 2023

Instance eessi-bot-mc-aws is configured to build:

  • arch x86_64/generic for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/generic for repo eessi-hpc.org-2023.06-software
  • arch x86_64/generic for repo eessi.io-2023.06-compat
  • arch x86_64/generic for repo eessi.io-2023.06-software
  • arch x86_64/intel/haswell for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/intel/haswell for repo eessi-hpc.org-2023.06-software
  • arch x86_64/intel/haswell for repo eessi.io-2023.06-compat
  • arch x86_64/intel/haswell for repo eessi.io-2023.06-software
  • arch x86_64/intel/skylake_avx512 for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/intel/skylake_avx512 for repo eessi-hpc.org-2023.06-software
  • arch x86_64/intel/skylake_avx512 for repo eessi.io-2023.06-compat
  • arch x86_64/intel/skylake_avx512 for repo eessi.io-2023.06-software
  • arch x86_64/amd/zen2 for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/amd/zen2 for repo eessi-hpc.org-2023.06-software
  • arch x86_64/amd/zen2 for repo eessi.io-2023.06-compat
  • arch x86_64/amd/zen2 for repo eessi.io-2023.06-software
  • arch x86_64/amd/zen3 for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/amd/zen3 for repo eessi-hpc.org-2023.06-software
  • arch x86_64/amd/zen3 for repo eessi.io-2023.06-compat
  • arch x86_64/amd/zen3 for repo eessi.io-2023.06-software
  • arch aarch64/generic for repo eessi-hpc.org-2023.06-compat
  • arch aarch64/generic for repo eessi-hpc.org-2023.06-software
  • arch aarch64/generic for repo eessi.io-2023.06-compat
  • arch aarch64/generic for repo eessi.io-2023.06-software
  • arch aarch64/neoverse_n1 for repo eessi-hpc.org-2023.06-compat
  • arch aarch64/neoverse_n1 for repo eessi-hpc.org-2023.06-software
  • arch aarch64/neoverse_n1 for repo eessi.io-2023.06-compat
  • arch aarch64/neoverse_n1 for repo eessi.io-2023.06-software
  • arch aarch64/neoverse_v1 for repo eessi-hpc.org-2023.06-compat
  • arch aarch64/neoverse_v1 for repo eessi-hpc.org-2023.06-software
  • arch aarch64/neoverse_v1 for repo eessi.io-2023.06-compat
  • arch aarch64/neoverse_v1 for repo eessi.io-2023.06-software

@boegel boegel added the 2023.06-software.eessi.io 2023.06 version of software.eessi.io label Nov 25, 2023
@boegel boegel mentioned this pull request Nov 25, 2023
Closed
@bedroge
Copy link
Collaborator

bedroge commented Nov 25, 2023

Not sure if it's absolutely required, but it would definitely be nice to have this one merged as well (new container images for eessi.io, also with updated packages):
EESSI/filesystem-layer#163

@trz42
Copy link
Collaborator

trz42 commented Nov 26, 2023

Changes look ok. Small comment, it does not yet address #349. Maybe worthwhile to add changes as done in NorESSI#167

@trz42
Copy link
Collaborator

trz42 commented Nov 27, 2023

Rerunning tests to verify if CI succeeds after having EasyBuild ingested (see #393).

@bedroge
Copy link
Collaborator

bedroge commented Nov 27, 2023

The CI does pass, but there's actually still an error:

just run check_missing_installations.sh (should use easystacks/software.eessi.io/2023.06/eessi-2023.06-*.yml)
ls: cannot access 'easystacks/software.eessi.io/2023.06/eessi-2023.06-eb-*.yml': No such file or directory

@boegel
Copy link
Contributor Author

boegel commented Nov 27, 2023

The CI does pass, but there's actually still an error:

just run check_missing_installations.sh (should use easystacks/software.eessi.io/2023.06/eessi-2023.06-*.yml)
ls: cannot access 'easystacks/software.eessi.io/2023.06/eessi-2023.06-eb-*.yml': No such file or directory

That was because this branch was not updated yet with 2023.06-software.eessi.io after #393 was merged, see test results in for merge commit ccee5c5

@boegel
make sure that CI workflow for check_missing_installation.sh script u…
f882ff3 
…ses correct CPU target, by setting $EESSI_SOFTWARE_SUBDIR_OVERRIDE
@boegel
Copy link
Contributor Author

boegel commented Nov 27, 2023

Changes look ok. Small comment, it does not yet address #349. Maybe worthwhile to add changes as done in NorESSI#167

@trz42 fixed in f882ff3

@boegel boegel marked this pull request as ready for review November 27, 2023 13:32
trz42
trz42 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@trz42 trz42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@trz42 trz42 merged commit 1ec8084 into EESSI:2023.06-software.eessi.io Nov 27, 2023
32 checks passed
@boegel boegel deleted the 2023.06-software.eessi.io_ci-missing-installations branch November 27, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trz42 trz42 trz42 approved these changes

Assignees
No one assigned
Labels
2023.06-software.eessi.io 2023.06 version of software.eessi.io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI for testing if EESSI stack is available is only checking single architecture
3 participants
@boegel @bedroge @trz42