install CUDA under host_injections #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instance
|
|
I believe all the changes for software.eessi.io have been made in this PR, but still need to test... |
casparvl
changed the title
casparvl
changed the title
…the required GPU components in host_injections. The EESSI-install-software.sh has been modified to run install_scripts.sh early on and then run the actual installed scripts to install a full cuda SDK and drivers. This should enable building and using CUDA software anywhere down the line in this same environment
ocaisa
approved these changes
Dec 19, 2023
|
This needs to actually be deployed, but the deployment is coming in #434 so I think it's ok to merge as is |
ocaisa
reviewed
Dec 19, 2023
| @@ -187,6 +187,22 @@ fi | |||
| # assume there's only one diff file that corresponds to the PR patch file | |||
| pr_diff=$(ls [0-9]*.diff | head -1) | |||
|
|
|||
| # install any additional required scripts | |||
| # order is important: these are needed to install a full CUDA SDK in host_injections | |||
| install_scripts_changed=$(cat ${pr_diff} | grep '^+++' | cut -f2 -d' ' | sed 's@^[a-z]/@@g' | grep '^install_scripts.sh$' > /dev/null; echo $?) | |||
There was a problem hiding this comment.
@casparvl I messed up a little by merging this as now the file checked here will not be updated in the other PR, and as a result the scripts will not get installed. It doesn't matter too much as I think the use of $pr_diff is overkill here. I think we should always run the installer script and instead of using cp use cp -u, that could be implemented as part of #434
Also, this was a little wrong anyway, as it doesn't check if the scripts installed by the installer have changed
ocaisa
reviewed
Dec 19, 2023
| # Install full CUDA SDK in host_injections | ||
| # Hardcode this for now, see if it works | ||
| # TODO: We should make a nice yaml and loop over all CUDA versions in that yaml to figure out what to install | ||
| ${EESSI_CVMFS_REPO}/gpu_support/nvidia/install_cuda_host_injections.sh 12.1.1 |
There was a problem hiding this comment.
Wow, I really messed up here...the arguments are incorrect!
ocaisa
reviewed
Dec 19, 2023
|
|
||
| # Copy files from this directory into the prefix | ||
| # To be on the safe side, we dont do recursive copies, but we are explicitely copying each individual file we want to add | ||
| for file in install_cuda_host_injections.sh link_nvidia_host_injections.sh; do |
boegel
changed the title
TopRichard
added a commit
to TopRichard/bot-software-layer1
that referenced
this pull request
Jun 17, 2024
…mory_per_node_option_1 Use default memory option during reframe tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replicates #368 for the 2023.06-pilot repo