-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use --from-commit
instead of --from-pr
for installations done with EasyBuild v4.9.1
#558
base: 2023.06-software.eessi.io
Are you sure you want to change the base?
use --from-commit
instead of --from-pr
for installations done with EasyBuild v4.9.1
#558
Conversation
Instance
|
Instance
|
@boegel I'm not entirely sure how this works, but I'm wondering if we shouldn't use the merge commit itself instead of the last commit in the PR? For instance, with the one for Bioconductor you're now using the last commit which actually synced with develop, and using
The older Bioconductor easyconfigs, which are also updated by that same PR, are not included, is that expected? In other words, what would have happened if our software layer PR would have needed one of those? The merge commit itself (f8fa6c791dc009696b6cd0280d549163c5b65e38) does return the following files (which is mor ein line with what I expected):
If it does not really matter for the builds themselves, I'm fine with either approach, just wondering how this works. |
In NorESSI#344, I first used the merge commit in easybuilders/easybuild-easyconfigs#20379. This failed, because some easyconfig was not available. I then used the last commit before the merge commit. Still the builds failed (maybe for another reason ... have to check). Edit: Now it fails building the extension |
I think we have to just enforce this going forward right? We can't really tweak older easystack files as, for reproducibility, they are tied to an EasyBuild release...and We can easily add a CI check to ensure that |
This doesn't affect the ingested installations at all, but going forward we should use
--from-commit
instead of--from-pr
, and simply use the last commit in the (merged) PR