Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use EESSI pilot repo for testing test suite (for now) #104

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

boegel
Copy link
Contributor

@boegel boegel commented Jan 29, 2024

Fix for indirect switch to software.eessi.io in #102

We have to keep using the EESSI pilot repo for now, since software.eessi.io does not provide GROMACS yet (cfr. EESSI/software-layer#401)

@satishskamath satishskamath self-requested a review January 30, 2024 09:39
@satishskamath satishskamath merged commit cd1725b into EESSI:main Jan 30, 2024
9 checks passed
@casparvl
Copy link
Collaborator

casparvl commented Jan 30, 2024

I'm fine with this as a workaround, but I think the issue might be in the pattern we check for when dry-running. If there is no module named GROMACS then no gromacs test is created. ReFrame will print some kind of warning (or error?) that there was a test with undefined variables (namely: the variable reframe.core.pipeline.RegressionTest.modules wasn't defined). This should be a perfectly acceptable dryrun. So whatever pattern we check for, this should pass. If not, we should change the pattern :)

@boegel
Copy link
Contributor Author

boegel commented Jan 30, 2024

@casparvl OK, let's look into that in a follow-up PR then.

Switching back to the pilot repo for now was the easiest way to fix the broken CI situation...

@boegel boegel deleted the ci_pilot_repo branch January 30, 2024 16:59
@satishskamath
Copy link
Collaborator

The same thing is happening with OSU now, the test passes of course but OSU is not available with these warnings:

WARNING: skipping test 'osu_pt_2_pt': test has one or more undefined parameters
WARNING: skipping test 'osu_coll': test has one or more undefined parameters

@smoors
Copy link
Collaborator

smoors commented Jan 31, 2024

pilot EESSI version 2023.06 does not contain any OSU modules, which are needed to test the OSU PR

@boegel
Copy link
Contributor Author

boegel commented Jan 31, 2024

@satishskamath @smoors should be fixed with #105...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants