Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find and report on duplicate modules #167

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

laraPPr
Copy link
Collaborator

@laraPPr laraPPr commented Aug 6, 2024

No description provided.

@laraPPr laraPPr added the bug fix label Aug 6, 2024
@laraPPr
Copy link
Collaborator Author

laraPPr commented Aug 6, 2024

Possible fix for #132

@laraPPr
Copy link
Collaborator Author

laraPPr commented Aug 6, 2024

Gives a warning and does not create any tests if it find duplicate modules for a test.
So if one duplicate module of LAMMPS is found it will not create any LAMMPS tests but it will create the other tests (at least if they don't have any duplicate tests).
The error includes a list of the duplicate modules that triggered the error.

Copy link
Collaborator

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a few style suggestions

eessi/testsuite/utils.py Outdated Show resolved Hide resolved
Co-authored-by: Sam Moors <smoors@users.noreply.github.com>
Copy link
Collaborator

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works well, thanks a lot @laraPPr !

@smoors smoors merged commit 8d74234 into EESSI:main Aug 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants