Fix CI for new ReFrame 4.6.2 #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owever, this is only possible if running with the reframe command, since that command adds the 'external' directory in the reframe installation prefix to the sys.path. In other words: ReFrame is never supposed to be imported directly, that simply does not work (by design).
bedroge
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReFrame 4.6.2 got deployed in EESSI, and is now picked up by the CI. The module is different in that the
externalfolder within the ReFrame installation prefix is no longer on thePYTHONPATH. As a result,python -c "import reframe"doesn't work anymore - and note that this is by design. One should never import ReFrame directly, but only in a ReFrame test that is run by thereframecommand. Thereframecommand then adds theexternalfolder to thesys.path. The advantage of this setup is that only ReFrame picks up on those python deps inexternalfolder, it doesn't polute thePYTHONPATH.This PR removes the line that does
python -c 'import eessi.testsuite.utils', since that is not supposed to work: it indirectly importsreframe, which is not supposed to work, as explained before.