This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
Fix wildcard-in-the-middle for US-military.xml #12314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See EFForg#4369. Only these subdomains seem to be matched by a regexp.
ghost
mentioned this pull request
How did you find these domains? I tried searching Google but it had no results, and I don't know if that's because there really are no domains matching the pattern |
|
Just check the regex on line 56 :) TL;DR - it's anyway only two domains this target was applied to. |
|
Oh okay, thanks. I've added another item to the checklist to delete the |
|
@RReverser Can we move forward on this one? |
|
I'm closing this pull request in favor of my pull request #14011. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4369. Only these subdomains seem to be matched by a regexp.