This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
Report and remove overlapping targets #12320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I've noticed many XML have targets that actually overlap and so unnecessarily duplicate each other. I've extended target checks to test and report this automatically as reducing them might partially help with EFForg#12232.
RReverser
force-pushed
the
test-target-overlap
branch
from
054d5fa
to
48bd6fc
Compare
|
Added automated attempt to remove targets that were detected as already covered by others in the same ruleset. As I said in #12322 (comment), I'm not sure if this will always give correct result because sometimes it's the wildcard target that can be avoided, but I think it might be better for the start and can be corrected manually after. |
This was referenced Sep 1, 2017
RReverser
changed the title
|
(feel free to merge the check separately from XML changes if that's easier / makes more sense) |
J0WI
reviewed
Sep 3, 2017
| @@ -1,7 +1,6 @@ | |||
| <ruleset name="3min" default_off="Invalid Certificate"> | |||
| <target host="3min.de"/> | |||
| <target host="*.3min.de"/> | |||
| <target host="www.3min.de"/> | |||
There was a problem hiding this comment.
In some cases we cold replace the target with a test url.
|
Reviewing this now. |
|
Looks great, thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed many XML have targets that actually overlap and so unnecessarily duplicate each other.
I've extended target checks to test and report this automatically as reducing them might partially help with #12232.