Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Fix JS errors found by LGTM.com #19254

Merged
merged 6 commits into from
May 18, 2020
Merged

Fix JS errors found by LGTM.com #19254

merged 6 commits into from
May 18, 2020

Conversation

cschanaj
Copy link
Collaborator

@cschanaj cschanaj commented May 9, 2020

No description provided.

@pipboy96 pipboy96 changed the title Fix access to let-bound variable in temporal dead zone Fix JS errors found by LGTM.com May 9, 2020
@pipboy96 pipboy96 added the bug label May 9, 2020
@pipboy96
Copy link
Contributor

pipboy96 commented May 9, 2020

May I recommend another rule to add: https://eslint.org/docs/rules/eqeqeq

@cschanaj
Copy link
Collaborator Author

cschanaj commented May 9, 2020

May I recommend another rule to add: https://eslint.org/docs/rules/eqeqeq

I am afraid this is too far from the scope of this PR. I am interested in adding "extends": "eslint:recommended" and fix the errors in a later PR. We shall add more Best Practices rules including eqeqeq there as well.

@cschanaj cschanaj closed this May 9, 2020
@cschanaj cschanaj reopened this May 9, 2020
@cschanaj cschanaj requested a review from zoracon May 9, 2020 09:08
@cschanaj cschanaj mentioned this pull request May 16, 2020
Closed
zoracon
zoracon approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@zoracon zoracon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out and tested locally

@zoracon zoracon merged commit 68425c9 into EFForg:master May 18, 2020
@cschanaj cschanaj deleted the lgtm-com-found-js-error branch May 18, 2020 22:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zoracon zoracon zoracon approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cschanaj @pipboy96 @zoracon