Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V6 API Migration #111

Merged
merged 5 commits into from
Apr 7, 2021
Merged

V6 API Migration #111

merged 5 commits into from
Apr 7, 2021

Conversation

ApolloZhu
Copy link
Member

@ApolloZhu ApolloZhu commented Dec 19, 2020 •
edited
Loading

See V6 API Announcement for details

  • Migrate Playgrounds
  • Migrate watchOS tests
  • Migrate other XCTests
  • Migrate demo projects
  • Produce migration guide
  • Migration demo videos

@ApolloZhu ApolloZhu self-assigned this Dec 19, 2020
@ApolloZhu ApolloZhu added this to the v6.x.x milestone Dec 19, 2020
@ApolloZhu ApolloZhu changed the base branch from main to objc December 19, 2020 04:12
@ApolloZhu ApolloZhu mentioned this pull request Dec 19, 2020
Merged
@codecov-io
Copy link

codecov-io commented Dec 19, 2020 •
edited
Loading

Codecov Report

Merging #111 (aa665c0) into main (0f2a0dd) will decrease coverage by 3.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
- Coverage   61.50%   58.35%   -3.16%     
==========================================
  Files          15       15              
  Lines         982      982              
==========================================
- Hits          604      573      -31     
- Misses        378      409      +31
Impacted Files Coverage Δ
Source/EFQRCode+Migration-v6.swift 0.00% <0.00%> (-45.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f2a0dd...aa665c0. Read the comment docs.

@ApolloZhu ApolloZhu force-pushed the v6-migration branch 3 times, most recently from 0af93d9 to f624f23 Compare December 20, 2020 02:36
Base automatically changed from objc to main December 20, 2020 08:40
@ApolloZhu ApolloZhu force-pushed the v6-migration branch 3 times, most recently from f2930c2 to 6137bb7 Compare December 26, 2020 13:19
@filsv
Copy link

filsv commented Apr 7, 2021

@ApolloZhu Hi, when WatchOS compatibility will be fixed?

@ApolloZhu ApolloZhu marked this pull request as ready for review April 7, 2021 16:53
@ApolloZhu
Copy link
Member Author

@filsv that should have been fixed in https://github.com/EFPrefix/EFQRCode/releases/tag/6.0.0 (a pre-release). If you are using an earlier version, see #85 for instructions.

@ApolloZhu ApolloZhu merged commit a931132 into main Apr 7, 2021
@ApolloZhu ApolloZhu deleted the v6-migration branch April 7, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ApolloZhu ApolloZhu

Labels
example
Projects
None yet
Milestone
v6.x.x
Development

Successfully merging this pull request may close these issues.
3 participants
@ApolloZhu @codecov-io @filsv