Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable behaviour of whole-day appointments in calendar-view #76

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cit-gruenewald
Copy link

@ralfbecker
Copy link
Member

ralfbecker commented Mar 21, 2020

Hi Jan,

problem with (missing) German translation is simple to explain: you did not use translation-tools and your manual editing messed up the file-format ;)

$phrase\t$appname\t$lang\t$translation

So the 4 parts of a line are tab-separated, not some number or space, might also be caused by your editor.

I also noted the funny indention in your added code, probably caused by indenting with n-space, but we use tabs.

Please fix this.

Thanks for contributing to EGroupware :)

Ralf

@cit-gruenewald
Copy link
Author

cit-gruenewald commented Mar 23, 2020

Hi Ralf,

sure will do. Is 4 spaces == 1 tab the only guideline?

Where do I find the translation tool?
Edit I'll find out about translations.

@cit-gruenewald
Copy link
Author

Hi Ralf,

I'm using PHPStorm. I tried to adjust the style-settings to resemble the existing code as good as possible. I hope that suffices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants