Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/logging and default secret key #241

Merged
merged 2 commits into from
Jun 18, 2022
Merged

Fix/logging and default secret key #241

merged 2 commits into from
Jun 18, 2022

Conversation

aspedrosa
Copy link
Contributor

@aspedrosa aspedrosa commented May 11, 2022 •
edited
Loading

  1. Our logging configurations were not showing HTTP 500. Configured in a way that keeps django's default loggers, which automatically log HTTP 500.
  2. Add a default secret key so development and test environments are easier to set up. If the default key is used on production a warning is issued.

Note: github actions errors addressed on #243

@aspedrosa aspedrosa changed the base branch from master to dev May 11, 2022 11:16
@aspedrosa aspedrosa closed this May 11, 2022
@aspedrosa aspedrosa reopened this May 11, 2022
@joaorafaelalmeida joaorafaelalmeida merged commit 62e1597 into dev Jun 18, 2022
@joaorafaelalmeida joaorafaelalmeida deleted the fix/logging_and_default_secret_key branch June 18, 2022 18:05
@joaorafaelalmeida joaorafaelalmeida mentioned this pull request Jun 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaorafaelalmeida joaorafaelalmeida joaorafaelalmeida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aspedrosa @joaorafaelalmeida