new/Create a dashboard view #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 2, 2022 14:57
joaorafaelalmeida
requested changes
Jun 18, 2022
joaorafaelalmeida
approved these changes
Jun 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bioinformatics-ua/montra-pvt#1967
When opening the database dashboard on the EHDEN Portal of a database that has not yet uploaded Achilles files into the platform the following will appear:
As the issue at the top mentions, a message should be presented instead of rendering the dashboard with "no results" on the charts.
Implementation
Created a new view/endpoint
uploader/[db hash]/dashboardwhich checksIf one of these conditions fails, the following simple page will render:
else the view/endpoint will redirect to Superset's database dashboard
from
dashboards.ehden.eu/uploader/[db hash]/dashboardtohttps://superset.ehden.eu/superset/dashboard/database-level-dashboard/?standalone=1&preselect_filters=%7B%2269%22:%7B%22acronym%22:[%22DB_HASH%22]%7D%7D.I tested on an iframe and the redirect works nicely.
Note: github actions errors addressed on #243