Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models identical in cDNA but not in CDS considered redundant by Mikado prepare #127

Closed
lucventurini opened this issue Sep 27, 2018 · 1 comment
Assignees
Milestone

Comments

@lucventurini
Copy link
Collaborator

Mikado prepare does consider only the exonic structure when discarding models – not the CDS. So if two models were identical in terms of exons but had a different CDS (say, because only one model had its ORF called) Mikado would still consider the pair “redundant”. This is not a problem for how we used Mikado so far (ie on transcript assemblies and/or PacBio reads) but in rare cases might have led to the loss of models in some loci.

To make the type of situation clearer: presume to have four models, A, A’, A’’ and A’’’, all on the same strand and with two exons: (1001, 1500) and (1700, 2000). Model A does not have any CDS. Model A’ has an ORF with coordinates (1201, 1470). Model A’’ has an ORF with coordinates (1401, 1900). Model A’’’ is identical to model A’’. At the moment, as they have the same exonic coordinates, Mikado would consider these four models identical and keep only one of these (chosen randomly).

The expected and desired behaviour is that only one between A’’ and A’’’ will be discarded (as they have also an identical CDS).

lucventurini added a commit that referenced this issue Sep 27, 2018
…ion broke when I tried to keep the features of each model in memory. Now time to create unit tests to verify the new behaviour.
lucventurini added a commit that referenced this issue Sep 27, 2018
@lucventurini lucventurini modified the milestones: 0.10, 1.3 Oct 5, 2018
@lucventurini
Copy link
Collaborator Author

Properly tested. Closing.

lucventurini added a commit to lucventurini/mikado that referenced this issue Feb 11, 2021
… thought as the function broke when I tried to keep the features of each model in memory. Now time to create unit tests to verify the new behaviour.
lucventurini added a commit to lucventurini/mikado that referenced this issue Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants