Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CDS] Make mikado (prepare?) check verify whether an ORF has start and/or stop codon #132

Closed
lucventurini opened this issue Oct 5, 2018 · 1 comment
Closed

[CDS] Make mikado (prepare?) check verify whether an ORF has start and/or stop codon #132

lucventurini opened this issue Oct 5, 2018 · 1 comment
Assignees
@gemygk @lucventurini
Labels
enhancement
Milestone
2.0

Comments

@lucventurini
Copy link
Collaborator

Currently, Mikado does not check whether a transcript with an inherent CDS has a complete ORF. This is problematic as it prevents Mikado from fully using CDS-related metrics for models that do not have a UTR (e.g. aligned proteins).

As Mikado prepare already pulls up the sequence, it should be easy to check this on-line.
@lucventurini lucventurini added this to the 1.3 milestone Oct 5, 2018
lucventurini added a commit that referenced this issue Oct 5, 2018
@lucventurini
Solved #132, with one unit-testing confirming
bfc1f16
lucventurini added a commit that referenced this issue Oct 6, 2018
@lucventurini
New test correctly implemented for #132
bfca61c
@lucventurini
Copy link
Collaborator Author

Feature correctly implemented. Closing.

lucventurini added a commit to lucventurini/mikado that referenced this issue Feb 11, 2021
@lucventurini
Solved EI-CoreBioinformatics#132, with one unit-testing confirming
0379c91
lucventurini added a commit to lucventurini/mikado that referenced this issue Feb 11, 2021
@lucventurini
New test correctly implemented for EI-CoreBioinformatics#132
6275cc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gemygk gemygk

@lucventurini lucventurini

Labels
enhancement
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@gemygk @lucventurini