Proper backend support #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, I will merge it into a new branch and work on fixing the imports |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the result of the discussion from #11.
The aim was to be able to use different backends, without the need to install all backends. This is useful as torch/tf often collides, which may hinder people to use staintools out-of-the-box.
What I did was to make subpackages within the main package, totally stratified into three packages: base, tf_backend, torch_backend. The numpy backend is part of the base, as both tf and torch depends on numpy. I also added more CIs to properly verify that it works, but more can be added if necessary. But it should be fine for now.
Last that remains is to simplify imports, as mentioned #11 (comment).
Milestones: