Fix/lega commander installation and readme #321
Conversation
- Default to `/usr/local/bin` for system-wide installation - Fallback to `~/.local/bin` if `/usr/local/bin` is not writable - Added error messages with guidance to use `sudo` or the `-b` flag for custom paths
…are required to regenerate badges.
kjellp
force-pushed
the
fix/lega-commander-install
branch
from
d981a21 to
50cbd9a
Compare
|
I tested the install script on Linux now, and ran into errors: I downdloaded the install.script manually from the branch in the repo, and executed it locally with the -b option to install it in a custom location not requiring sudo. There is a 404 error in there related to fetching the Linux_x86_64 tar.gz file. @Parisa68 is it this specific version of the release file that only will be generated upon the PR merge? |
|
The install script searches into the release with the latest tag. Crypt4gh is having the latest tag, so it is trying to download it. It fails because the url is wrong. Do we need that the Crypt4gh also has the latest tag? |
|
we can try to keep lega-commander-assets "latest"(the solution should be tested), but is that what we want or we want to change the script to work specifically for lega commander? |
|
I would say the latter, update the script to fetch the latest build of the lega-commander specificly if possible.
K.
…________________________________
From: Parisa ***@***.***>
Sent: Wednesday, January 8, 2025 3:37 PM
To: ELIXIR-NO/FEGA-Norway ***@***.***>
Cc: Kjell Petersen ***@***.***>; Comment ***@***.***>
Subject: Re: [ELIXIR-NO/FEGA-Norway] Fix/lega commander installation and readme (PR #321)
we can try to keep lega-commander-assets "latest"(the solution should be tested), but is that what we want or we want to change the script to work specifically for lega commander?
—
Reply to this email directly, view it on GitHub<#321 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABAHO7VWKWA6ZTTS77PYO6L2JUZ3NAVCNFSM6AAAAABTYAYMEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZXHAZTAMJYHA>.
You are receiving this because you commented.Message ID: ***@***.***>
[External email] Make sure you recognize the sender's email address before you click links, open attachments, or get involved in financial transactions. Contact IT-support BRITA if you have any questions.
|
Updated Install Script:
Adjusted the GITHUB_DOWNLOAD logic to use the correct repository (ELIXIR-NO/FEGA-Norway).
Changed handling of TAG and VERSION logic to support the monorepo structure.
Removed Deprecated Adjustments: Removed unused adjust_os and adjust_arch functions following GoReleaser deprecations.
Improved Logging: Enhanced log messages to provide clearer status updates during installation (e.g., success, failure).
Windows Compatibility:
Improved defaults: BINDIR defaults to /usr/local/bin or user-provided path.
Confirmed instalation for Linux and Mac
Updated installation instructions in README.md and removed old badges