Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rolls back change to article IX #15

Merged
merged 3 commits into from
Jun 8, 2018
Merged

Conversation

thomasbcox
Copy link
Contributor

rolls back the change made around May 30, where the default forum was switched from ECAF to ICC, the International Chamber of Commerce's arbitration forum

rolls back the change made around May 30, where the default forum was switched from ECAF to ICC, the International Chamber of Commerce's arbitration forum
@thomasbcox
Copy link
Contributor Author

Please do not merge this PR until it's been thoroughly discussed

Copy link

@DMTrueBlock DMTrueBlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that the ECAF is a new body but is capable of handling cases that come to it. Further, it is crucial that EOSIO can govern itself.

@DenisCarriere
Copy link
Contributor

Added checksums & ipfs for both eosio.system & eosio.token ABI

ipfs.txt

added QmdiEnPy2ZprjGe3vfxikg9fNaJR77bbMcVMBwWh64ajCm eosio.system.abi
added QmTgfMfMw2zQgtkeSu7iJfaVcWbmU8werBjYuf6iVseFXL eosio.token.abi

checksums.txt

b15749b745ccbbce4a2ef9e6139c84cad131ddd2582713b1f545b7b489e8f394  ./eosio.system/eosio.system.abi
804533704bfa098d2399808a806cb37cc4256da3ce9b0d9a777b3ab21c4fe778  ./eosio.token/eosio.token.abi

@DenisCarriere DenisCarriere merged commit 7d55af2 into master Jun 8, 2018
@kesar
Copy link
Contributor

kesar commented Jun 8, 2018

I think the way that we are merging and adding code could improve a lot.

  • Who decided to add checksums, IPFS & scripts?
  • Who support this change? Do we need 3 votes to change the constitution?

I am aware that this get more votes over telegram chats, but I think it should be explicit somewhere here, otherwise those votes will get lost. Even if I like this PR, I think the work around the acceptance is poor.

I guess IPFS & extra scripts are for bios boot. I don't this that there is an agreement between BPs to use that. This could end up with every BP boot adding more and more files here.

I also think that if someone adds code, it should request a review from somebody else. It didn't happen.

More suggestions ( #16 )

@DenisCarriere
Copy link
Contributor

DenisCarriere commented Jun 8, 2018

@kesar I added ipfs and checksums to make sure we have this file already hosted and someone can easily grab them.

However I do agree, we can keep this Github repo "lean" and remove any extra scripts or extra supporting files, only stick with what's needed.

@kesar
Copy link
Contributor

kesar commented Jun 8, 2018

yes, just to avoid confusion, I think content of PR is great, and that you are all doing your best ❤️

Just wanted to point some stuff that we could improve in the future 👍

@DenisCarriere
Copy link
Contributor

@kesar agreed, that last commit should of been in it's own PR (or discussed prior to merging).

👍

DenisCarriere added a commit to EOS-Mainnet/eos that referenced this pull request Jun 8, 2018
@DenisCarriere DenisCarriere deleted the article-9-icc-to-ecaf branch June 9, 2018 02:05
abourget pushed a commit that referenced this pull request Jun 19, 2019
Update eosio.system-rentnet-rc.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants