Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Commit

Permalink
Remove fc's bz2 unused linkage
Browse files Browse the repository at this point in the history
fc links to bz2 but this isn't required. Nothing uses bz2 and the HAS_BZIP2 macro that is set is not used anywhere. Remove this as it causes a runtime dependency that is 100% unneeded
  • Loading branch information
spoonincode committed Apr 27, 2018
1 parent 08cab1d commit 142ccba
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions libraries/fc/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -138,15 +138,6 @@ else()
set( ZLIB_LIBRARIES "" )
endif( ZLIB_FOUND )

find_package( BZip2 )
if( BZIP2_FOUND )
MESSAGE( STATUS "bzip2 found" )
add_definitions( -DHAS_BZIP2 )
else()
MESSAGE( STATUS "bzip2 not found" )
set( BZIP2_LIBRARIES "" )
endif( BZIP2_FOUND )

# This will become unnecessary once we update to websocketpp which fixes upstream issue #395
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DWEBSOCKETPP_STRICT_MASKING")
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DBOOST_ASIO_HAS_STD_CHRONO")
Expand All @@ -162,7 +153,7 @@ target_include_directories(fc
IF(NOT WIN32)
set(LINK_USR_LOCAL_LIB -L/usr/local/lib)
ENDIF()
target_link_libraries( fc PUBLIC ${LINK_USR_LOCAL_LIB} ${Boost_LIBRARIES} ${OPENSSL_LIBRARIES} ${ZLIB_LIBRARIES} ${BZIP2_LIBRARIES} ${PLATFORM_SPECIFIC_LIBS} ${RPCRT4} ${CMAKE_DL_LIBS} ${rt_library} ${readline_libraries} ${ECC_LIB} )
target_link_libraries( fc PUBLIC ${LINK_USR_LOCAL_LIB} ${Boost_LIBRARIES} ${OPENSSL_LIBRARIES} ${ZLIB_LIBRARIES} ${PLATFORM_SPECIFIC_LIBS} ${RPCRT4} ${CMAKE_DL_LIBS} ${rt_library} ${readline_libraries} ${ECC_LIB} )


SET(OPENSSL_CONF_TARGET )
Expand Down

3 comments on commit 142ccba

@466919153
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is setup_library ?

CMake Error at CMakeLists.txt:121 (setup_library):
Unknown CMake command "setup_library".

@466919153
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who solved this problem ?

@466919153
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who can tell me ? help !

Please sign in to comment.