Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

p2p network txn handling, new constants, socket options #393

Closed
pmesnier opened this issue Sep 10, 2017 · 2 comments
Closed

p2p network txn handling, new constants, socket options #393

pmesnier opened this issue Sep 10, 2017 · 2 comments

Comments

@pmesnier
Copy link
Contributor

Relates to #291, cleans up txn handling, define constants for new magic numbers, add setting the NODELAY socket option.

@pmesnier
Copy link
Contributor Author

I've named several magic numbers in net_plugin.cpp. This adds 9 potentially configurable values to the four existing. I think it would be a good idea to add either section names or prefixes to config options to avoid potential namespace collisions. For instance, change listen-endpoint, public-endpoint, and remote-endpoint to be p2p-listen-endpoint, etc. then the new values when added could be p2p-.

In fact, we don't need to do that to all config.ini options, http-server-endpoint is clear, as is plugin and producer-name.

@pmesnier
Copy link
Contributor Author

closing, solution was merged in pr #403.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants