Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Compile issue on v.1.8.0-rc1 #7251

Closed
HuweyII opened this issue May 2, 2019 · 5 comments
Closed

Compile issue on v.1.8.0-rc1 #7251

HuweyII opened this issue May 2, 2019 · 5 comments
Assignees

Comments

@HuweyII
Copy link

HuweyII commented May 2, 2019

This is a fresh VM, running Ubuntu 18.04LTS

Last bit of compile looks like this
`[ 77%] Building CXX object libraries/fc/CMakeFiles/fc.dir/src/compress/zlib.cpp.o

In file included from /export/vol01/v1.8.0-rc1/libraries/fc/src/compress/zlib.cpp:3:0:
/export/vol01/v1.8.0-rc1/libraries/fc/src/compress/miniz.c: In function ‘void tdefl_find_match(tdefl_compressor*, mz_uint, mz_uint, mz_uint, mz_uint*, mz_uint*)’:
/export/vol01/v1.8.0-rc1/libraries/fc/src/compress/miniz.c:2290:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
if (!dist) break; q = (const mz_uint16*)(d->m_dict + probe_pos); if (TDEFL_READ_UNALIGNED_WORD(q) != s01) continue; p = s; probe_len = 32;
^~
/export/vol01/v1.8.0-rc1/libraries/fc/src/compress/miniz.c:2290:23: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
if (!dist) break; q = (const mz_uint16*)(d->m_dict + probe_pos); if (TDEFL_READ_UNALIGNED_WORD(q) != s01) continue; p = s; probe_len = 32;
^

[ 77%] Linking CXX static library libfc.a
[ 77%] Built target fc
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2`

@spoonincode
Copy link
Contributor

The excerpt you pasted appears to only be a warning. You may need to scroll further back to find the error.

@spoonincode
Copy link
Contributor

possibly #7260

@NorseGaud
Copy link
Contributor

zlib isn't installing properly due to a build script error:
The script has if [ ! -d $OPT_LOCATION/zlib || $FORCE_BUILD ]; then which is wrong. I've got a fix in for this in #7285

@NorseGaud NorseGaud self-assigned this May 7, 2019
@NorseGaud
Copy link
Contributor

@HuweyII Are you certain you've done a git submodule update --init --recursive --force and can replicate the error?

@andriantolie
Copy link
Contributor

andriantolie commented Jun 26, 2019

I've tried using a fresh AWS instance with Ubuntu18.04 and I can confirm that this issue can be replicated in v1.8.0-rc1. On another instance, I can also confirm that this issue has been fixed in the latest release/1.8.x. I'm going to close this issue as it's been fixed in the latest version. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants