Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Use of Mac Anka Fleet instead of iMac fleet #7285

Merged
merged 14 commits into from
May 7, 2019
Merged

Conversation

NorseGaud
Copy link
Contributor

@NorseGaud NorseGaud commented May 6, 2019

Problem: Current Parallels/iMac fleet requires a human to create new images anytime dependencies change in the build scripts. Not only that, but we cannot free up a buildkite agent to pick up a different kind of job if it's just sitting around not doing anything and it's setup for a specific purpose (mac osx with xcode 10.2 OR nightly "clean" vms).

Solution: The Mac Anka fleet provides the flexibility of on-demand buildkite runs across mac minis with 12 cores and 32G of memory. Half of the fleet is limited to a single buildkite-agent, using the entire 12 cores; The other half runs two buildkite-agents with 6 cores each. This should greatly increase the performance and speed of running builds (which will use 12 cores) and tests (which only need 6). VM image layers are created just like docker and then pulled onto the host when we need them (or it uses the local copy if it's already been downloaded before).

@NorseGaud NorseGaud requested review from zreyn and larryk85 May 6, 2019 19:06
@NorseGaud
Copy link
Contributor Author

Building new images for linux...

@NorseGaud NorseGaud removed the request for review from larryk85 May 7, 2019 13:48
Copy link
Contributor

@zreyn zreyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the changes look fine. I left a few comments/questions, though only one is directly related to anka.

scripts/eosio_build_ubuntu.sh Outdated Show resolved Hide resolved
scripts/serial-test.sh Outdated Show resolved Hide resolved
scripts/serial-test.sh Show resolved Hide resolved
.buildkite/pipeline.yml Show resolved Hide resolved
.buildkite/pipeline.yml Show resolved Hide resolved
kj4ezj
kj4ezj previously requested changes May 7, 2019
Copy link
Contributor

@kj4ezj kj4ezj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding work, just a couple of changes I recommend :)

scripts/parallel-test.sh Show resolved Hide resolved
scripts/parallel-test.sh Outdated Show resolved Hide resolved
scripts/parallel-test.sh Outdated Show resolved Hide resolved
scripts/parallel-test.sh Show resolved Hide resolved
scripts/parallel-test.sh Show resolved Hide resolved
.buildkite/pipeline.yml Show resolved Hide resolved
.buildkite/pipeline.yml Show resolved Hide resolved
.buildkite/pipeline.yml Show resolved Hide resolved
.buildkite/pipeline.yml Show resolved Hide resolved
.buildkite/pipeline.yml Show resolved Hide resolved
@NorseGaud NorseGaud dismissed kj4ezj’s stale review May 7, 2019 19:55

Issues addressed

@NorseGaud NorseGaud merged commit d9ce416 into develop May 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants