This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Use of Mac Anka Fleet instead of iMac fleet #7285
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building new images for linux... |
zreyn
suggested changes
May 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the changes look fine. I left a few comments/questions, though only one is directly related to anka.
kj4ezj
previously requested changes
May 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outstanding work, just a couple of changes I recommend :)
zreyn
approved these changes
May 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Current Parallels/iMac fleet requires a human to create new images anytime dependencies change in the build scripts. Not only that, but we cannot free up a buildkite agent to pick up a different kind of job if it's just sitting around not doing anything and it's setup for a specific purpose (mac osx with xcode 10.2 OR nightly "clean" vms).
Solution: The Mac Anka fleet provides the flexibility of on-demand buildkite runs across mac minis with 12 cores and 32G of memory. Half of the fleet is limited to a single buildkite-agent, using the entire 12 cores; The other half runs two buildkite-agents with 6 cores each. This should greatly increase the performance and speed of running builds (which will use 12 cores) and tests (which only need 6). VM image layers are created just like docker and then pulled onto the host when we need them (or it uses the local copy if it's already been downloaded before).