Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Change blockvault client plugin initialization log message #10109

Merged
merged 4 commits into from
Apr 27, 2021

Conversation

huangminghuang
Copy link
Contributor

Change Description

This PR changes how blockvault client plugin log message during initialization. If the plugin is not enabled, no log message would be shown.

Change Type

Select ONE:

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Testing Changes

Select ANY that apply:

  • New Tests
  • Existing Tests
  • Test Framework
  • CI System
  • Other

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@huangminghuang huangminghuang requested a review from heifner March 4, 2021 15:47
@@ -44,6 +43,9 @@ void blockvault_client_plugin::plugin_initialize(const variables_map& options) {
elog("unknown block-vault-backend option, skipping it");
}
}
else {
ilog("no block-vault-backend option is specified, skipping it");
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally the plugin would not initialize at all if not specified. But chain_plugin requires blockvault_client_plugin currently. Would be great if that was not the case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going to make that change, we need to do that in a Jira task just for that specifically.

@@ -44,6 +43,9 @@ void blockvault_client_plugin::plugin_initialize(const variables_map& options) {
elog("unknown block-vault-backend option, skipping it");
}
}
else {
ilog("no block-vault-backend option is specified, skipping it");
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going to make that change, we need to do that in a Jira task just for that specifically.

Copy link
Contributor

@brianjohnson5972 brianjohnson5972 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since it could be a simple change, let's at least look

@huangminghuang huangminghuang merged commit 237f7d6 into develop Apr 27, 2021
@huangminghuang huangminghuang deleted the huangminghuang/bv-initialization-message branch May 5, 2021 15:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants