-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Change blockvault client plugin initialization log message #10109
Change blockvault client plugin initialization log message #10109
Conversation
@@ -44,6 +43,9 @@ void blockvault_client_plugin::plugin_initialize(const variables_map& options) { | |||
elog("unknown block-vault-backend option, skipping it"); | |||
} | |||
} | |||
else { | |||
ilog("no block-vault-backend option is specified, skipping it"); | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally the plugin would not initialize at all if not specified. But chain_plugin requires blockvault_client_plugin currently. Would be great if that was not the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are going to make that change, we need to do that in a Jira task just for that specifically.
@@ -44,6 +43,9 @@ void blockvault_client_plugin::plugin_initialize(const variables_map& options) { | |||
elog("unknown block-vault-backend option, skipping it"); | |||
} | |||
} | |||
else { | |||
ilog("no block-vault-backend option is specified, skipping it"); | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are going to make that change, we need to do that in a Jira task just for that specifically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since it could be a simple change, let's at least look
Change Description
This PR changes how blockvault client plugin log message during initialization. If the plugin is not enabled, no log message would be shown.
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions