Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

amqp shutdown hang #10111

Merged
merged 1 commit into from
Mar 5, 2021
Merged

amqp shutdown hang #10111

merged 1 commit into from
Mar 5, 2021

Conversation

heifner
Copy link
Contributor

@heifner heifner commented Mar 5, 2021

Change Description

  • The amqp_trace_plugin was blocking on shutdown calling amqp::stop() since the channel was unusable and would not call onFinalize or onError. Add a check for if channel is usable. Also added an onError which should not be necessary but figure it can't hurt anything.

Change Type

Select ONE:

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Testing Changes

Select ANY that apply:

  • New Tests
  • Existing Tests
  • Test Framework
  • CI System
  • Other

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@heifner heifner requested a review from swatanabe-b1 March 5, 2021 02:54
@heifner heifner merged commit 634657f into develop-boxed Mar 5, 2021
@heifner heifner deleted the shutdown-amqp branch March 5, 2021 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants