This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
EPE-672: Added unit test framework #10112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusty-block-one
requested review from
brianjohnson5972,
dexterhuang-blockone and
huangminghuang
and removed request for
dexterhuang-blockone
huangminghuang
approved these changes
Mar 5, 2021
Needed to remove a line
dimas1185
reviewed
Mar 5, 2021
plugins/net_plugin/test/main.cpp
Outdated
| } | ||
|
|
||
| boost::unit_test::test_suite* init_unit_test_suite(int argc, char* argv[]) { | ||
| // Turn off blockchain logging if no --verbose parameter is not added |
There was a problem hiding this comment.
this sentence sounds awkward. Maybe something like "Turn off logging if --verbose parameter was not provided" ?
There was a problem hiding this comment.
Reworded the sentence
dimas1185
reviewed
Mar 5, 2021
plugins/net_plugin/test/main.cpp
Outdated
|
|
||
| boost::unit_test::test_suite* init_unit_test_suite(int argc, char* argv[]) { | ||
| // Turn off blockchain logging if no --verbose parameter is not added | ||
| // To have verbose enabled, call "tests/chain_test -- --verbose" |
There was a problem hiding this comment.
please rename "chain_test". Maybe tests/ ?
dimas1185
reviewed
Mar 5, 2021
plugins/net_plugin/test/main.cpp
Outdated
|
|
||
| std::srand(time(NULL)); | ||
| std::cout << "Random number generator seeded to " << time(NULL) << std::endl; | ||
| /* |
There was a problem hiding this comment.
is this comment necessary? if it is, please explain how use that code.
dimas1185
reviewed
Mar 5, 2021
plugins/net_plugin/test/main.cpp
Outdated
| #include <fc/log/logger.hpp> | ||
| #include <eosio/chain/exceptions.hpp> | ||
|
|
||
| //extern uint32_t EOS_TESTING_GENESIS_TIMESTAMP; |
There was a problem hiding this comment.
likely needs to be removed
dimas1185
suggested changes
Mar 5, 2021
heifner
reviewed
Mar 5, 2021
1) Removed unused code 2) Clarified comments 3) Disabled cmake processing until a test is added
brianjohnson5972
suggested changes
Mar 8, 2021
dimas1185
approved these changes
Mar 8, 2021
brianjohnson5972
approved these changes
Mar 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Added unit test framework for net_plugin.
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions