This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Adding test for nodeos --full-version check. #10120
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamblevins
force-pushed
the
wlb/adding_nodeos_param_tests
branch
3 times, most recently
from
March 10, 2021 21:02
3f0f3d4
to
0c20b34
Compare
williamblevins
force-pushed
the
wlb/adding_nodeos_param_tests
branch
from
March 10, 2021 22:03
0c20b34
to
1f4421e
Compare
williamblevins
force-pushed
the
wlb/adding_nodeos_param_tests
branch
2 times, most recently
from
March 11, 2021 19:15
3f6bb1b
to
5a09514
Compare
williamblevins
force-pushed
the
wlb/adding_nodeos_param_tests
branch
from
March 11, 2021 20:00
5a09514
to
cb9ef32
Compare
williamblevins
force-pushed
the
wlb/adding_nodeos_param_tests
branch
from
March 11, 2021 22:54
5ce9e25
to
0516869
Compare
kj4ezj
suggested changes
Mar 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Also note that we will have to make these changes on eos:release/2.1.x
and eos:release/2.0.x
. We technically still support eos:release/1.8.x
as well so it might be nice to back-port these changes to that branch, but the --full-version
flag does not exist for that branch, I am not sure about --print-build-info
, and the --version
test will still need the "or no-op" (|| :
).
williamblevins
force-pushed
the
wlb/adding_nodeos_param_tests
branch
from
March 15, 2021 17:54
dfb5bc1
to
7bdfaef
Compare
kj4ezj
approved these changes
Mar 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for AUTO-588!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Adding tests for
nodeos
parameters--full-version
and--print-build-info
.Test for
--print-build-info
checksboost_version
. I had originally planned to check thecompiler
output also, but it was a little less intuitive.Output from the unit tests taken from Mac 10.15 https://buildkite.com/EOSIO/eosio/builds/27451#e1dd9247-ae1b-4a0b-a17f-e1eec1dc4937 which I checked specifically because of needing to and the env parameters.
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions