Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Adding test for nodeos --full-version check. #10120

Merged
merged 11 commits into from
Mar 15, 2021

Conversation

williamblevins
Copy link
Collaborator

@williamblevins williamblevins commented Mar 9, 2021

Change Description

Adding tests for nodeos parameters --full-version and --print-build-info.

Test for --print-build-info checks boost_version. I had originally planned to check the compiler output also, but it was a little less intuitive.

Output from the unit tests taken from Mac 10.15 https://buildkite.com/EOSIO/eosio/builds/27451#e1dd9247-ae1b-4a0b-a17f-e1eec1dc4937 which I checked specifically because of needing to and the env parameters.

test 123
--
  | Start 123: version-label-test
  |  
  | 123: Test command: /Users/anka/eos/build/tests/version-label.sh
  | 123: Test timeout computed to be: 1500
  | 123: ##### Nodeos Version Label Test #####
  | 123: Using EOSIO_ROOT="/Users/anka/eos/".
  | 123: Parsing "/Users/anka/eos//build/CMakeCache.txt"...
  | 123: Expecting "v2.1.0-rc1"...
  | 123: Passed with "v2.1.0-rc1".
  | 106/109 Test #123: version-label-test .................................   Passed    0.03 sec
  | test 124
  | Start 124: full-version-label-test
  |  
  | 124: Test command: /Users/anka/eos/build/tests/full-version-label.sh
  | 124: Test timeout computed to be: 1500
  | 124: ##### Nodeos Full Version Label Test #####
  | 124: Using EOSIO_ROOT="/Users/anka/eos/".
  | 124: Parsing "/Users/anka/eos//build/CMakeCache.txt"...
  | 124: Expecting "v2.1.0-rc1-8573289d7c80f7acf9f3494ec6c6df7bbe7bf895"...
  | 124: Passed with "v2.1.0-rc1-8573289d7c80f7acf9f3494ec6c6df7bbe7bf895".
  | 107/109 Test #124: full-version-label-test ............................   Passed    0.03 sec
  | test 125
  | Start 125: print-build-info-test
  |  
  | 125: Test command: /Users/anka/eos/build/tests/print-build-info.sh
  | 125: Test timeout computed to be: 1500
  | 125: ##### Nodeos Print Build Info Test #####
  | 125: Using EOSIO_ROOT="/Users/anka/eos/".
  | 125: $ /Users/anka/eos//build/bin/nodeos --print-build-info 2>&1 \| tee >(cat - >&9) \|\| :
  | 125: info  2021-03-15T20:00:10.215 thread-0  blockvault_client_plug:35     plugin_initialize    ] initializing blockvault_client plugin
  | 125: info  2021-03-15T20:00:10.215 thread-0  chain_plugin.cpp:715          plugin_initialize    ] initializing chain plugin
  | 125: info  2021-03-15T20:00:10.215 thread-0  chain_plugin.cpp:730          plugin_initialize    ] Build environment JSON:
  | 125: {
  | 125:   "debug": false,
  | 125:   "os": "OS_MACOS",
  | 125:   "arch": "ARCH_X86_64",
  | 125:   "boost_version": 107200,
  | 125:   "compiler": "Clang 10.0.0 (https://github.com/llvm/llvm-project d32170dbd5b0d54436537b6b75beaf44324e0c28)"
  | 125: }
  | 125: warn  2021-03-15T20:00:10.215 thread-0  chain_plugin.cpp:1285         plugin_initialize    ] 3100009 node_management_success: Node management operation successfully executed
  | 125: reported build environment information
  | 125:     {}
  | 125:     thread-0  chain_plugin.cpp:747 plugin_initialize
  | 125:
  | 125: Failed to initialize
  | 125: ARCH: "ARCH_X86_64"
  | 125: BOOST_VERSION: 107200
  | 125: COMPILER: "Clang 10.0.0 (https://github.com/llvm/llvm-project d32170dbd5b0d54436537b6b75beaf44324e0c28)"
  | 125: DEBUG: false
  | 125: OS: "OS_MACOS"
  | 125: Verifying boost version: "107200" == "107200".
  | 125: Validation of build info complete.
  | 108/109 Test #125: print-build-info-test ..............................   Passed    0.19 sec

Change Type

Select ONE:

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Testing Changes

Select ANY that apply:

  • New Tests
  • Existing Tests
  • Test Framework
  • CI System
  • Other

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@williamblevins williamblevins force-pushed the wlb/adding_nodeos_param_tests branch 3 times, most recently from 3f0f3d4 to 0c20b34 Compare March 10, 2021 21:02
@williamblevins williamblevins force-pushed the wlb/adding_nodeos_param_tests branch from 0c20b34 to 1f4421e Compare March 10, 2021 22:03
@williamblevins williamblevins force-pushed the wlb/adding_nodeos_param_tests branch 2 times, most recently from 3f6bb1b to 5a09514 Compare March 11, 2021 19:15
@williamblevins williamblevins force-pushed the wlb/adding_nodeos_param_tests branch from 5a09514 to cb9ef32 Compare March 11, 2021 20:00
@williamblevins williamblevins force-pushed the wlb/adding_nodeos_param_tests branch from 5ce9e25 to 0516869 Compare March 11, 2021 22:54
@williamblevins williamblevins marked this pull request as ready for review March 11, 2021 23:48
@williamblevins williamblevins requested a review from kj4ezj March 11, 2021 23:49
Copy link
Contributor

@kj4ezj kj4ezj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Also note that we will have to make these changes on eos:release/2.1.x and eos:release/2.0.x. We technically still support eos:release/1.8.x as well so it might be nice to back-port these changes to that branch, but the --full-version flag does not exist for that branch, I am not sure about --print-build-info, and the --version test will still need the "or no-op" (|| :).

tests/version-label.sh Show resolved Hide resolved
tests/version-label.sh Show resolved Hide resolved
tests/print-build-info.sh Show resolved Hide resolved
tests/print-build-info.sh Outdated Show resolved Hide resolved
tests/full-version-label.sh Outdated Show resolved Hide resolved
tests/full-version-label.sh Show resolved Hide resolved
@williamblevins williamblevins force-pushed the wlb/adding_nodeos_param_tests branch from dfb5bc1 to 7bdfaef Compare March 15, 2021 17:54
Copy link
Contributor

@kj4ezj kj4ezj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for AUTO-588!

@kj4ezj kj4ezj merged commit d63073c into develop Mar 15, 2021
@kj4ezj kj4ezj deleted the wlb/adding_nodeos_param_tests branch March 15, 2021 20:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants