This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Reliable amqp_trx_plugin & amqp_trace_plugin #10127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Add reliability options to
amqp_trx_plugin
&amqp_trace_plugin
amqp_trace_plugin
now has configurable reliability viaamqp-trace-reliable-mode
amqp_trace_plugin
now has configurable queue viaamqp-trace-queue-name
option.amqp_trx_plugin
now has configurable queue viaamqp-trx-queue-name
option.reliable_amqp_publisher
.reliable_amqp_publisher
now callson_fatal_error
callback instead of dropping messages which in all cases callsapp().quit()
now.amqp_handler
to usesingle_channel_retrying_amqp_connection
to provide reliability and to move away from unsupportedAMQP::LibBoostAsioHandler
.Note: A follow-on PR is planned that will separate
amqp_trace_plugin
fromamqp_trx_plugin
.Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions
Documentation Additions
--amqp-trace-queue-name arg (=trace) AMQP queue to publish transaction
traces.
--amqp-trace-reliable-mode arg (=queue)
Reliable mode 'exit', exit application
on any AMQP publish error.
Reliable mode 'queue', queue
transaction traces to send to AMQP on
connection establishment.
Reliable mode 'log', log an error and
drop message when unable to directly
publish to AMQP.
--amqp-trx-queue-name arg (=trx) AMQP queue to consume transactions
from.