Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Separate amqp_trx_plugin from amqp_trace_plugin #10141

Merged
merged 5 commits into from
Mar 19, 2021

Conversation

heifner
Copy link
Contributor

@heifner heifner commented Mar 16, 2021

Change Description

  • amqp_trx_plugin no longer depends on amqp_trace_plugin for sending transaction traces to AMQP. amqp_trace_plugin still exists and provides ability to send all transaction traces to AMQP. amqp_trx_plugin is setup to only send transaction traces for transactions that it processes.
  • The AMQP reply-to-queue pattern is now used by amqp_trx_plugin. If a reply-to is sent with the transaction then the trace will be send to the AMQP default exchange connection with that routing-key. The correlation-id is set to the transaction id. If a reply-to is not specified then no trace is sent to AMQP.

Change Type

Select ONE:

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Testing Changes

Select ANY that apply:

  • New Tests
  • Existing Tests
  • Test Framework
  • CI System
  • Other

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions
  --amqp-trx-trace-reliable-mode arg (=queue)
                                        Reliable mode 'exit', exit application
                                        on any AMQP publish error.
                                        Reliable mode 'queue', queue
                                        transaction traces to send to AMQP on
                                        connection establishment.
                                        Reliable mode 'log', log an error and
                                        drop message when unable to directly
                                        publish to AMQP.

heifner added 2 commits March 16, 2021 07:59
…p_trace_plugin functionality. Added optional RPC reply-to-queue pattern.
Base automatically changed from reliable-amqp-plugins to develop-boxed March 18, 2021 13:22
@heifner heifner marked this pull request as ready for review March 18, 2021 17:07
@heifner heifner requested a review from swatanabe-b1 March 18, 2021 17:07
@heifner heifner merged commit bfdba24 into develop-boxed Mar 19, 2021
@heifner heifner deleted the amqp-trx-trace-split branch March 19, 2021 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants