This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Consolidated Security Updates for 2.0.12 - develop #10272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Apply three-strikes rule to all transaction failures - Apply unconditional subjective CPU check along with some additional logging - Provide options to enable subjective CPU billing for P2P and API transactions ,and provide an option to disable it for individual accounts Co-Authored-By:Kevin Heifner heifnerk@objectcomputing.com Co-Authored-By:Lin Huang lin.huang@block.one
heifner
changed the title
heifner
suggested changes
Apr 20, 2021
heifner
reviewed
Apr 20, 2021
| @@ -457,14 +459,14 @@ class producer_plugin_impl : public std::enable_shared_from_this<producer_plugin | |||
| future.wait(); | |||
| app().post( priority::low, [self, future{std::move(future)}, persist_until_expired, next{std::move( next )}, trx{std::move(trx)}]() mutable { | |||
| auto exception_handler = [self, &next, trx{std::move(trx)}](fc::exception_ptr ex) { | |||
| fc_dlog(_trx_failed_trace_log, "[TRX_TRACE] Speculative execution is REJECTING tx: ${txid} : ${why} ", | |||
| ("txid", trx->id())("why",ex->what())); | |||
| fc_dlog(_trx_failed_trace_log, "[TRX_TRACE] Speculative execution is REJECTING tx: ${txid}, auth: ${a} : ${why} ", | |||
There was a problem hiding this comment.
We use 3 spaces mostly in our code base.
heifner
approved these changes
Apr 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidated Security Updates for 2.0.12
Apply three-strikes rule to all transaction failures
Apply unconditional subjective CPU check along with some additional logging
Provide options to enable subjective CPU billing for P2P and API transactions ,and provide an option to disable it for individual accounts
v2.0.x - #10264
Co-Authored-By:Kevin Heifner heifnerk@objectcomputing.com
Co-Authored-By:Lin Huang lin.huang@block.one
Change Type
Select ONE:
Testing Changes
Select ANY that apply: