This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
net_plugin fix for privacy groups corner case #10390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Fixed test case that required node restart in
privacy_scenario_3_test.py
Scenario:
after
node1
launched it sends handshake tonode2
node1
is not in security group sonode2
doesn't send back any notice (lib catchup notice was required in that case)node1
was added to security group andnode2
sends tonode1
handshakein
sync 1
scenario, whennet_plugin
receives non-first handshake with lib greater its own lib it do nothing.This fix adds sending handshake there also in case of non-first handshake generation
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions