Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

net_plugin fix for privacy groups corner case #10390

Merged
merged 3 commits into from
May 26, 2021
Merged

Conversation

dimas1185
Copy link
Contributor

Change Description

Fixed test case that required node restart in privacy_scenario_3_test.py

Scenario:
after node1 launched it sends handshake to node2
node1 is not in security group so node2 doesn't send back any notice (lib catchup notice was required in that case)
node1 was added to security group and node2 sends to node1 handshake
in sync 1 scenario, when net_plugin receives non-first handshake with lib greater its own lib it do nothing.
This fix adds sending handshake there also in case of non-first handshake generation

Change Type

Select ONE:

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Testing Changes

Select ANY that apply:

  • New Tests
  • Existing Tests
  • Test Framework
  • CI System
  • Other

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@brianjohnson5972 brianjohnson5972 requested a review from heifner May 22, 2021 04:59
Copy link
Contributor

@brianjohnson5972 brianjohnson5972 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also like Kevin to look at this.

plugins/net_plugin/net_plugin.cpp Show resolved Hide resolved
@brianjohnson5972 brianjohnson5972 self-requested a review May 25, 2021 14:28
@dimas1185 dimas1185 merged commit a7b5566 into develop May 26, 2021
@dimas1185 dimas1185 deleted the feature-privacy-fix branch May 26, 2021 23:09
praphael pushed a commit that referenced this pull request Jun 11, 2021
dimas1185 pushed a commit that referenced this pull request Aug 14, 2021
@dimas1185 dimas1185 mentioned this pull request Aug 14, 2021
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants