This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
fix bug in trace_api_plugin no params returned GH issue 10435 / EPE 1066 https://github.com/EOSIO/eos/issues/10435 #10449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wn by abi_serializer when no return data is present
|
Related issue #10435 |
praphael
changed the title
victorj8
approved these changes
Jun 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
In trace API plugin, if RPC ABIS are specified with --trace-rpc-abi, the 'params' field of the returned transaction JSON did not exist. This was caused by an exception being thrown in chain::abi_serializer, when the return_value field did not exist, it would thrown an 'Unpack exception' even though action params were serialized correctly. Fixes issue #10435
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions