This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Don't Always Push to DockerHub #10485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kj4ezj
suggested changes
Jul 9, 2021
.cicd/helpers/general.sh
Outdated
Comment on lines
10
to
16
| if [[ "$BUILDKITE_PIPELINE_SLUG" =~ "security" ]] ; then | ||
| export CI_REGISTRIES=("$DOCKERHUB_CI_REGISTRY" "$MIRROR_REGISTRY") | ||
| export CONTRACT_REGISTRIES=("$DOCKERHUB_CONTRACTS_REGISTRY" "$MIRROR_REGISTRY") | ||
| else | ||
| export CI_REGISTRIES=("$MIRROR_REGISTRY") | ||
| export CONTRACT_REGISTRIES=("$MIRROR_REGISTRY") | ||
| fi |
There was a problem hiding this comment.
I think this logic is backwards.
There was a problem hiding this comment.
Yeah, good catch. I think CONTRACTS flags are turned off in the pipeline, so I wasn't paying enough attention ;(
williamblevins
force-pushed
the
develop_sec_no_pub_docker
branch
from
80c6acb to
85e13a5
Compare
kj4ezj
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
From AUTO-1016, we have downstream consumers of our CI systems who may not want to push to DockerHub. This pull request allows these downstream consumers who are running our CI code to push to internal registries exclusively.
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions