This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
disable undo_stack by default, set tested typical rocksdb configurati… #10547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on parameters if options file is not provided, and gives detailed warning if deprecated rdb-threads and rdb-max-files are used
heifner
suggested changes
Jul 19, 2021
programs/rodeos/cloner_plugin.cpp
Outdated
| @@ -302,7 +302,7 @@ void cloner_plugin::set_program_options(options_description& cli, options_descri | |||
| op("filter-name", bpo::value<std::string>(), "Filter name"); | |||
| op("filter-wasm", bpo::value<std::string>(), "Filter wasm"); | |||
| op("profile-filter", bpo::bool_switch(), "Enable filter profiling"); | |||
| op("disable-undo-stack", bpo::bool_switch(), "disable undo stack"); | |||
| op("undo-stack", bpo::bool_switch(), "Enable undo stack"); | |||
There was a problem hiding this comment.
The description calls this enable-undo-stack which I think would be better.
There was a problem hiding this comment.
I would suggest not to use bool_swich and use bpo::value<bool>(); in case if we want to change the default back to enabled in the future, we can just change the default value instead of the option name.
There was a problem hiding this comment.
Done. Thanks.
heifner
approved these changes
Jul 19, 2021
heifner
approved these changes
Jul 20, 2021
This was referenced Sep 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on parameters if options file is not provided, and gives detailed warning if deprecated rdb-threads and rdb-max-files are used
Change Description
For the convenience of users and less prone to make mistakes, undo_stack is disabled by default,
and
--enable-undo-stackis required to enable it; if options file is not provided, typical rocksdb configurationparameters will be used; If
--rdb-threadsand--rdb-max-filesare used, rodeos will not start and detailed warning is given.Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions