This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
rodeos: Add support for stream_wapper_v1 with std::string route 📦 #10606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ilog("logger stream [${data_size}] >> ${data}", ("data", data)("data_size", data.size())); | ||
| void publish(const std::vector<char>& data, const std::string& routing_key) override { | ||
| ilog("logger stream ${r}: [${data_size}] >> ${data}", | ||
| ("r", routing_key)("data", data)("data_size", data.size())); |
There was a problem hiding this comment.
The order of "data" and "data_size" is reversed.
There was a problem hiding this comment.
The order doesn't matter.
linhuang-blockone
approved these changes
Aug 10, 2021
eosio::name is limited to 12 characters but routing keys in rabbitmq has no such restriction. This allows users to use much more reasonable sized routing keys. |
This was referenced Sep 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
stream_wrapper_v1withstd::stringroute which removes the restriction to useeosio::namefor routing keys.Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions