This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
4297 delegatebw with buyram #4635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I know, you could do two separate actions, the first buying ram for the account and then delegate the resources with the delegatebw action |
wanderingbort
suggested changes
Jul 14, 2018
programs/cleos/main.cpp
Outdated
| wdump((act_payload)); | ||
| send_actions({create_action({permission_level{from_str,config::active_name}}, config::system_account_name, N(delegatebw), act_payload)}); | ||
| if (buy_ram_amount.length()) { | ||
| fc::variant act_payload = fc::mutable_variant_object() |
There was a problem hiding this comment.
Instead of duplicating this action in both sides of the branches can we assembly the vector of actions incrementally so that this action is always in it, the buyram is appended based on conditions and there is only a single call to send_actions with the result?
wanderingbort
approved these changes
Jul 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4297 add --buyram parameter to delegatebw. This will helps the dead accounts(zero cpu/net stake, no available ram) to revive. But it needs to be executed in a fast producer node so that it can be finished within the cpu leeway limit(default 3ms).
command example: