This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
add guard track to database #4666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to setting the size you can now set a minimum guard on the chain state db. If there is a db-growing operation called on controller while this guard is violated it will throw and the node should dhutdown gracefully. related to EOSIO#4555
| @@ -19,6 +19,7 @@ const static auto default_reversible_cache_size = 340*1024*1024ll;/// 1MB * 340 | |||
| const static auto default_state_dir_name = "state"; | |||
| const static auto forkdb_filename = "forkdb.dat"; | |||
| const static auto default_state_size = 1*1024*1024*1024ll; | |||
| const static auto default_state_guard_size = 512*1024ll; | |||
There was a problem hiding this comment.
Since this is divided by 1024*1024 in chain_plugin, I'm guessing you are missing a *1024 here
| @@ -341,6 +342,9 @@ void chain_plugin::plugin_initialize(const variables_map& options) { | |||
| if( options.count( "chain-state-db-size-mb" )) | |||
| my->chain_config->state_size = options.at( "chain-state-db-size-mb" ).as<uint64_t>() * 1024 * 1024; | |||
|
|
|||
| if( options.count( "chain-state-db-guard-size-mb" )) | |||
There was a problem hiding this comment.
Forget this comment, missed it was a minimum size
There was a problem hiding this comment.
although this is fair, it looks like I was intending the track to be 512k... hrm
…n database cleanly exits when exhaustion occurs in replay
heifner
approved these changes
Jul 16, 2018
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to setting the size you can now set a minimum guard on the chain state db. If there is a db-growing operation called on controller while this guard is violated it will throw and the node should shutdown gracefully.
the config is:
chain-state-db-guard-size-mbdefaulted to 1MiBrelated to #4555