This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Present a clearer message on bad_alloc & return consistent error code #5895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We normally bet on the DB size guard to cleanly shut down nodeos when the free DB size becomes low. But one user (#5791) encountered a bad_alloc without the guard kicking in. We can't do better then an unclean shutdown but we can do better conveying the error.
Make a bad_alloc exception print a more clear message and make it exit with the same error code as main.cpp lists as BAD_ALLOC by getting rid of the unorthodox SIGUSR1. Also implicitly gets rid of a POSIXism.