Fix for transaction_traces store in mongo_db_plugin #6130

heifner · 2018-10-24T15:00:19Z

Change Description

transaction_traces were not stored if action_traces were not stored
Now transaction_traces are stored if enabled even if action_trace storage is disabled
Filtering is applied to transaction_traces even if action_trace storage is disabled

Resolves #6088

…e disabled. Filtering still applies.

brianjohnson5972 · 2018-10-24T15:55:38Z

plugins/mongo_db_plugin/mongo_db_plugin.cpp

@@ -809,8 +811,10 @@ mongo_db_plugin_impl::add_action_trace( mongocxx::bulk_write& bulk_action_traces
   }

   bool added = false;
-   if( start_block_reached && store_action_traces &&
-       filter_include( atrace.receipt.receiver, atrace.act.name, atrace.act.authorization ) ) {
+   bool in_filter = (store_action_traces || store_transaction_traces) && start_block_reached &&


Would prefer const bool in_filter since nothing else is changing

brianjohnson5972 · 2018-10-24T15:59:38Z

plugins/mongo_db_plugin/mongo_db_plugin.cpp

@@ -799,7 +800,8 @@ void mongo_db_plugin_impl::_process_accepted_transaction( const chain::transacti
 bool
 mongo_db_plugin_impl::add_action_trace( mongocxx::bulk_write& bulk_action_traces, const chain::action_trace& atrace,
                                        const chain::transaction_trace_ptr& t,
-                                        bool executed, const std::chrono::milliseconds& now )
+                                        bool executed, const std::chrono::milliseconds& now,
+                                        bool& write_ttrace )


Not sure what to do with it, but would like to point out that returning write_atrace (essentially) and setting a reference for write_ttrace doesn't make for a clear interface.

transaction_traces are now stored if enabled even if action_traces ar…

25d5073

…e disabled. Filtering still applies.

heifner requested a review from brianjohnson5972 October 24, 2018 15:00

brianjohnson5972 approved these changes Oct 24, 2018

View reviewed changes

Add const, peer review fix

dfaed93

brianjohnson5972 approved these changes Oct 24, 2018

View reviewed changes

heifner merged commit 7145ded into release/1.4.x Oct 24, 2018

heifner deleted the gh#6088-transaction-traces branch October 24, 2018 17:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for transaction_traces store in mongo_db_plugin #6130

Fix for transaction_traces store in mongo_db_plugin #6130

heifner commented Oct 24, 2018 •

edited

Loading

brianjohnson5972 Oct 24, 2018

brianjohnson5972 Oct 24, 2018

Fix for transaction_traces store in mongo_db_plugin #6130

Fix for transaction_traces store in mongo_db_plugin #6130

Conversation

heifner commented Oct 24, 2018 • edited Loading

brianjohnson5972 Oct 24, 2018

Choose a reason for hiding this comment

brianjohnson5972 Oct 24, 2018

Choose a reason for hiding this comment

heifner commented Oct 24, 2018 •

edited

Loading