This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Gh#6056 long startup #6164
Merged
Gh#6056 long startup #6164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -386,7 +386,10 @@ struct controller_impl { | |||
| db.undo(); | |||
| } | |||
|
|
|||
| ilog( "database initialized with hash: ${hash}", ("hash", calculate_integrity_hash())); | |||
| if( snapshot ) { | |||
| const auto hash = calculate_integrity_hash(); | |||
There was a problem hiding this comment.
Are there side-effects in calculate_integrity_hash that we want to occur even if the information logging is not turned on?
There was a problem hiding this comment.
No. Should have no side-effects.
There was a problem hiding this comment.
Nevermind, just read Bart's telegram and I see why we want to do this outside the ilog.
brianjohnson5972
approved these changes
Oct 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
As documented by #6056 some people are seeing slow startup. This is caused by
calculate_integrity_hash()taking a long time to run.Only call the startup
calculate_integrity_hashwhen starting from a snapshot to avoid delay.