This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
EOSIO.CDT test porting/contract refactor #6329
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t a time; all other tests compile and run
johndebord
changed the title
EOSIO.CDT unit test porting/contract refactor (DO NOT MERGE)
EOSIO.CDT test porting/contract refactor
Dec 19, 2018
larryk85
reviewed
Dec 20, 2018
larryk85
approved these changes
Jan 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rundown of Various Changes
All smart contracts have been refactored to be able to compile with
eosio-cpp
version 1.4.1.With that, the most up-to-date patterns have been implemented in their appropriate contracts.
All
CMakeLists.txt
files have been refactored to makeeos
loosely coupled witheosio.cdt
.Meaning that while building
eos
, the build system will check if theeosio.cdt
toolset has been installed. If it has been installed, then all contracts will build in accordance with theeosio.cdt
toolset. Else, each contracts' respective.wasm
and.abi
files will be copied* into the build folder during the compilation process in order to successfully run the unit tests.All unit tests in directory
eos/unittests/
have been refactored to get all tests up to date and passing,as well as to act in accordance with the new
contracts.hpp.in
file, which houses the interface to all contracts' respective.wasm
and.abi
generated files.All smoke tests in directory
eos/tests/
have also been ported to get tests up to date and passing.Obsolete and redundant contracts have been removed, and all
eosio.*
contracts have been moved to theeos/unittests/contracts/
directory.The
eos/contracts/
directory has been moved and renamed toeos/unittests/test-contracts/
.*Note that each contract now supplies its own pre-generated
.wasm
file in its respective directory.But not all contracts supply their respective
.abi
file; namely alltest_api*
test contracts.Consensus Changes
N/A
API Changes
N/A
Documentation Additions
Renaming and moving the
eos/contracts/
directory toeos/unittests/test-contracts/
conflicts with the current tutorials in the eosio developer portal. This move is to reinforce that smart contract developers should not look to theeos/unittests/test-contracts/
directory for production quality contract examples, but should instead be referred to theeosio.contracts
repository for well written/tested contracts.