This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
add a test that reduces the size of the producer set #6430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it does not create protocol level issues
heifner
suggested changes
Dec 4, 2018
| {N(bob), get_public_key(N(bob), "active")}, | ||
| {N(carol), get_public_key(N(carol), "active")} | ||
| }; | ||
| //wlog("set producer schedule to [alice,bob]"); |
| {N(alice), get_public_key(N(alice), "active")}, | ||
| {N(bob), get_public_key(N(bob), "active")} | ||
| }; | ||
| wlog("set producer schedule to [alice,bob,carol]"); |
There was a problem hiding this comment.
This should be [alice,bob], right?
heifner
approved these changes
Dec 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Add an additional test to the producer_schedule_tests that decreases the size of the producer set from 3 to 2
Add an additional test to the producer_schedule_tests that verifies that a proposed empty producer schedule cannot become active and will not cause gaps to form in the schedule versions of active producer schedules.
Consensus Changes
API Changes
Documentation Additions