This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
optimization when writing shared_blob data #6501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Kayan <taokayan13@gmail.com>
heifner
suggested changes
Dec 18, 2018
heifner
approved these changes
Dec 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
@taokayan analyzed the cost associated with the
resize+memcpyapproach to updating these buffers and discovered thatresizewas very slow. In addition, the default copy constructor forshared_blobhad the same issues.using
assigndirectly in both cases was a clear win.I've ported these changes from another branch @taokayan shared with so that they can be adopted for the 1.6.0-rc1 pre-release.
Consensus Changes
none
API Changes
none
Documentation Additions